Skip to content

Correct an enhanced-enum test to allow setters named values#1312

Merged
chloestefantsova merged 1 commit into
masterfrom
update_values_setter
Mar 10, 2022
Merged

Correct an enhanced-enum test to allow setters named values#1312
chloestefantsova merged 1 commit into
masterfrom
update_values_setter

Conversation

@chloestefantsova

Copy link
Copy Markdown
Contributor

We had a discussion with Erik about the static values setter in enums, and the conclusion is that they should be allowed. This PR adjusts a test accordingly.

@eernstg eernstg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except that I think we should keep one of those errors.

Comment thread LanguageFeatures/Enhanced-Enum/grammar_A10_t04.dart

@eernstg eernstg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thread resolved.

Comment thread LanguageFeatures/Enhanced-Enum/grammar_A10_t04.dart
copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 9, 2022
See dart-lang/co19#1312

Change-Id: Ie535a826a2997c45344486febbb8cc35a748496c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@chloestefantsova chloestefantsova merged commit f512453 into master Mar 10, 2022
copybara-service Bot pushed a commit to dart-lang/sdk that referenced this pull request Mar 17, 2022
2022-03-16 eernst@google.com Fixes needed based on roll f5124538 (dart-lang/co19#1323)
2022-03-14 sgrekhov@unipro.ru Fixes dart-lang/co19#1310. Add language version 2.16 (dart-lang/co19#1314)
2022-03-10 519320+chloestefantsova@users.noreply.github.com Correct an enhanced-enum test to alow setters named values (dart-lang/co19#1312)
2022-02-25 sgrekhov@unipro.ru dart-lang/co19#993. Added tests for Abi class
2022-02-25 sgrekhov@unipro.ru dart-lang/co19#1258. Added test for a generic enum which does have a regular-bounded instantiate-to-bounds result
2022-02-24 sgrekhov@unipro.ru Fixes dart-lang/co19#1308. Make `UriData` tests case-insensitive
2022-02-24 sgrekhov@unipro.ru dart-lang/co19#1258. Not regular-bounded enum test added
2022-02-21 irina.arkhipets@gmail.com Merge remote-tracking branch 'remotes/origin/weak-reference-fix'
2022-02-21 sgrekhov@unipro.ru Revert accidental commits
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception
2022-02-21 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1305. Some cascaded errors previously reported by CFE removed
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1260. Added test for callback that throws an exception
2022-02-21 sgrekhov@unipro.ru dart-lang/co19#1258. Added tests for overridden == operator
2022-02-20 sgrekhov@unipro.ru Fixes dart-lang/co19#1307. Remove overridden == operator from enum
2022-02-19 sgrekhov@unipro.ru dart-lang/co19#1260. Fixed tests that check attachment of the same object to finalizer several times
2022-02-18 irina.arkhipets@gmail.com dart-lang/co19#1260: Weak reference tests updated.
2022-02-18 sgrekhov@unipro.ru dart-lang/co19#1258. More implementing enums tests added
2022-02-17 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48412. Different issues fixed in Finalizer tests
2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer test improved
2022-02-17 sgrekhov@unipro.ru dart-lang/co19#1260. Minor code enhancement
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Typo fixed
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Fix attach to finalizer tests
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Finalizer tests fixed and refactored
2022-02-16 sgrekhov@unipro.ru dart-lang/co19#1260. Another WeakReference tests added
2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated.
2022-02-15 sgrekhov@unipro.ru Fixes dart-lang/sdkdart-lang/co19#48391. Use function with 'no-inline' to create a WeakReference and to lost link to its target
2022-02-15 irina.arkhipets@gmail.com dart-lang/co19#1260: Finalizer tests updated.
2022-02-14 sgrekhov@unipro.ru dart-lang/co19#130. Roll failure fixed

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-mac-release-simarm64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: Icc2bea05df29e00b671b2843af7c3c55fa45da35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237581
Reviewed-by: William Hesse <whesse@google.com>
@athomas athomas deleted the update_values_setter branch November 23, 2023 09:52
@athomas athomas restored the update_values_setter branch November 23, 2023 09:53
@athomas athomas deleted the update_values_setter branch November 23, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants